Re: [libvirt] [PATCH 4/4 V4] qemu:send-key: Implement the driver methods

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Jul 14, 2011 at 11:32:18AM +0800, Lai Jiangshan wrote:
> qemu driver just accept xt_kbd codeset's keycode, so the lib virtkey
> is used for translating keycodes from other codesets.
> 
> Signed-off-by: Lai Jiangshan <laijs cn fujitsu com>
> ---
>  src/qemu/qemu_driver.c       |   71 ++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor.c      |   17 ++++++++++
>  src/qemu/qemu_monitor.h      |    5 +++
>  src/qemu/qemu_monitor_json.c |   15 +++++++++
>  src/qemu/qemu_monitor_json.h |    5 +++
>  src/qemu/qemu_monitor_text.c |   49 +++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_text.h |    5 +++
>  7 files changed, 167 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 0ea182d..c93885b 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -8646,6 +8716,7 @@ static virDriver qemuDriver = {
>      .domainMigratePerform3 = qemuDomainMigratePerform3, /* 0.9.2 */
>      .domainMigrateFinish3 = qemuDomainMigrateFinish3, /* 0.9.2 */
>      .domainMigrateConfirm3 = qemuDomainMigrateConfirm3, /* 0.9.2 */
> +    .domainSendKey = qemuDomainSendKey, /* 0.9.3 */
>  };

s/0.9.3/0.9.4/

ACK with that fix

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|