[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 3/9] conf: virDomainNetDef points to (rather than contains) virtPortProfile



On 07/20/2011 12:21 AM, Laine Stump wrote:
The virtPortProfile in the domain interface struct is now a separately
allocated object *pointed to by* (rather than contained in) the main
virDomainNetDef object. This is done to make it easier to figure out
when a virtualPortProfile has/hasn't been specified in a particular
config.
---
  src/conf/domain_conf.c    |   17 ++++++++---------
  src/conf/domain_conf.h    |    2 +-
  src/qemu/qemu_command.c   |    4 ++--
  src/qemu/qemu_hotplug.c   |    2 +-
  src/qemu/qemu_migration.c |    4 ++--
  src/qemu/qemu_process.c   |    2 +-
  src/util/network.c        |   15 ++++++++++++---
  src/util/network.h        |    2 +-
  8 files changed, 28 insertions(+), 20 deletions(-)


ACK.  Splitting this did make reviewing 2 and 3 easier.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]