Re: [libvirt] [PATCH 00/13] New API: virDominDestroyWithFlags

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Jul 21, 2011 at 01:16:42PM +0200, Michal Privoznik wrote:
> On 21.07.2011 13:15, Daniel P. Berrange wrote:
> >On Thu, Jul 21, 2011 at 11:28:27AM +0200, Michal Privoznik wrote:
> >>This series creates new API which adds flags to
> >>virDomainDestroy. As mentioned here many times, it is
> >>a bad luck all APIs don't have flags parameter.
> >>
> >>Parameter for this might be needed to select different
> >>ways of destroying a domain. For example, qemu has 'quit'
> >>command, which force it to flush internal caches a thus
> >>preventing from data loss. Or vice versa - in cases
> >>where we are doing hypervisor assisted destroy we might
> >>want to send signals, because hypervisor is not responding.
> >>
> >>Currently, no new functionality is implemented, but
> >>this paves the way for creating multiple ways of domain
> >>destroying. Therefore, calling this new API is the same
> >>as calling its predecessor.
> >>
> >>Michal Privoznik (13):
> >>   destroy: Define new public API virDomainDestroyWithFlags
> >>   destroy: Wire up the remote protocol
> >>   destroy: Implement internal API for qemu driver
> >>   destroy: Implement internal API for ESX driver
> >>   destroy: Implement internal API for libxl driver
> >>   destroy: Implement internal API for lxc driver
> >>   destroy: Implement internal API for openvz driver
> >>   destroy: Implement internal API for phyp driver
> >>   destroy: Implement internal API for uml driver
> >>   destroy: Implement internal API for vbox driver
> >>   destroy: Implement internal API for vmware driver
> >>   destroy: Implement internal API for xen driver
> >>   destroy: Implement internal API for xenapi driver
> >
> >I would ACK this whole series if the API naming is fixed.
> >
> >Daniel
> What about:
> 
> virDomainDestroyFlags for API
> virDomainDestroyFlagsValues for flags enum

Yes, that would work


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|