Re: [libvirt] [PATCHv2 14/16] save: support bypass-cache flag in qemu.conf

["Daniel P. Berrange" <berrange redhat com>]

On Tue, Jul 19, 2011 at 10:20:37PM -0600, Eric Blake wrote:
> When auto-dumping a domain on crash events, or autostarting a domain
> with managed save state, let the user configure whether to imply
> the bypass cache flag.
> 
> * src/qemu/qemu.conf (auto_dump_bypass_cache, auto_start_bypass_cache):
> Document new variables.
> * src/qemu/libvirtd_qemu.aug (vnc_entry): Let augeas parse them.
> * src/qemu/qemu_conf.h (qemud_driver): Store new preferences.
> * src/qemu/qemu_conf.c (qemudLoadDriverConfig): Parse them.
> * src/qemu/qemu_driver.c (processWatchdogEvent, qemuAutostartDomain):
> Honor them.
> ---
> 
> v2: merge 9 and 16 of v1, rename direct to bypass_cache
> 
>  src/qemu/libvirtd_qemu.aug |    2 ++
>  src/qemu/qemu.conf         |   16 ++++++++++++++++
>  src/qemu/qemu_conf.c       |   10 +++++++++-
>  src/qemu/qemu_conf.h       |    5 ++++-
>  src/qemu/qemu_driver.c     |    8 ++++----
>  5 files changed, 35 insertions(+), 6 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|