[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 19/16] save: add virsh commands for manipulating save files



On Wed, Jul 20, 2011 at 02:54:25PM -0600, Eric Blake wrote:
> Now you can edit a saved state file even if you forgot to grab
> a dumpxml file prior to saving a domain.  Plus, in-place editing
> feels so much nicer.
> 
> * tools/virsh.c (cmdSaveImageDumpxml, cmdSaveImageDefine)
> (cmdSaveImageEdit): New commands.
> * tools/virsh.pod (save-image-dumpxml, save-image-define)
> (save-image-edit): Document them.
> ---
> 
> Needs the next patch to be testable.  'save-image-edit' feels a bit
> long, but I couldn't think of something shorter.  Should I keep the
> new save-image-* commands in the main domain group, or should I create
> a new save-image group, in case we add more later?

I think the main group is fine - we alreaddy have plenty of other
save related commands there.

> 
>  tools/virsh.c   |  178 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tools/virsh.pod |   31 ++++++++++
>  2 files changed, 209 insertions(+), 0 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]