[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] python: Fix makefile rule for code generation



2011/7/21 Daniel P. Berrange <berrange redhat com>:
> On Thu, Jul 21, 2011 at 01:47:14PM +0200, Matthias Bolte wrote:
>> Commit 8665f85523f0451c changed generated.stamp to $(GENERATE).stamp,
>> but missed one instance in the CLEANFILES list. This can break the
>> build in case the generated code is deleted but the .stamp file stays
>> around and therefore the code isn't regenerated.
>> ---
>>  python/Makefile.am |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/python/Makefile.am b/python/Makefile.am
>> index a4c9a6b..51f005d 100644
>> --- a/python/Makefile.am
>> +++ b/python/Makefile.am
>> @@ -71,7 +71,7 @@ install-data-local:
>>  uninstall-local:
>>       rm -f $(DESTDIR)$(pyexecdir)/libvirt.py
>>
>> -CLEANFILES= $(GENERATED) generated.stamp
>> +CLEANFILES= $(GENERATED) $(GENERATE).stamp
>>
>>  else
>>  all:
>
> ACK
>
> Daniel

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]