Re: [libvirt] [PATCH v2 01/13] destroy: Define new public API virDomainDestroyFlags

[Eric Blake <eblake redhat com>]

On 07/21/2011 10:08 AM, Michal Privoznik wrote:
> This introduces new API virDomainDestroyFlags to allow
> domain destroying with flags, as the existing API virDomainDestroy
> misses flags.
>
> The set of flags is defined in virDomainDestroyFlagsValues enum,
> which is currently commented, because it is empty.
>
> Calling this API with no flags set (@flags == 0) is equivalent calling
> virDomainDestroy.

We need a counterpart to this for virDomainShutdown.  Would you mind 
doing that as well?

> + *
> + * Calling this function with no @flags set (equal zero)
> + * is equivalent calling virDomainDestroy.

If you haven't already pushed, squash in this grammar fix:

Calling this function with no @flags set (equal to zero)
is equivalent to calling virDomainDestroy().

> +++ b/src/libvirt_public.syms
> @@ -469,6 +469,7 @@ LIBVIRT_0.9.3 {
>   LIBVIRT_0.9.4 {
>       global:
>           virDomainUndefineFlags;
> +        virDomainDestroyFlags;

Also, I've been sorting these within a release.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org