[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 07/16] save: wire up trivial save/restore flags implementations



On 07/21/2011 05:30 AM, Daniel P. Berrange wrote:
On Tue, Jul 19, 2011 at 10:20:30PM -0600, Eric Blake wrote:
For all hypervisors that support save and restore, the new API
now performs the same functions as the old.


VIR_ERR_CONFIG_UNSUPPORTED is not quite right and VIR_ERR_NO_SUPPORT
is used to indicate complete lack of the driver API impl.

So perhaps we should have an VIR_ERR_ARGUMENT_UNSUPPORTED ?


ACK to the patch with a different error code used.

I've now pushed this one using the new VIR_ERR_ARGUMENT_UNSUPPORTED. I also pushed 8-15 as uncontroversial.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]