[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 0/4] support the listenNetwork attribute in <graphics>



On Wed, Jul 20, 2011 at 04:11:11AM -0400, Laine Stump wrote:
> 
> This patch series resolves the following bug:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=703851
> 
> In short, it implements support for a new "listenNetwork" attribute in
> the domain's <graphics> element. When listenNetwork is specified,
> libvirt will look for a network of that name (from the networks that
> can be created within libvirt), and derive a listen address from the
> physical interface used to connect that network to the outside
> world. (More details are given in each commit message).

I think my main thought on this is whether we are being forward
thinking enough. The problems with the current 'listen' attribute

  - You can only list one address
  - The address is tied to a specific machine

The 'listenNetwork' attribute would solve the second, but do
nothing to solve the first.

I think we ought to thus use a subelement

   <graphics>
     <listen type='network' network='foo'/>
   </graphics>

   <graphics>
     <listen type='address' address='192.168.122.122'/>
     <listen type='address' address='10.0.0.1'/>
     <listen type='address' address='fec0:1:2::232'/>
   </graphics>


Yes, I know QEMU does not support listening on multiple addresses
yet, but QEMU really needs to be fixed in that respect. This
shouldn't stop us from structuring the XML nicely now.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]