[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator



2011/7/22 Eric Blake <eblake redhat com>:
> On 07/22/2011 07:56 AM, Matthias Bolte wrote:
>>
>> Also prepend $(AM_V_GEN).
>> ---
>>  src/Makefile.am |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 481caba..eef0669 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -90,7 +90,7 @@ EXTRA_DIST += $(srcdir)/util/virkeymaps.h
>> $(srcdir)/util/keymaps.csv \
>>
>>  $(srcdir)/util/virkeymaps.h: $(srcdir)/util/keymaps.csv       \
>>                $(srcdir)/util/virkeycode-mapgen.py
>> -       python
>> $(srcdir)/util/virkeycode-mapgen.py<$(srcdir)/util/keymaps.csv>$@
>> +       $(AM_V_GEN)$(PYTHON)
>> $(srcdir)/util/virkeycode-mapgen.py<$(srcdir)/util/keymaps.csv>$@
>
> ACK.
>
> Hmm, while you're at it, how about you also:
>
> chmod +x src/util/virkeycode-mapgen.py
>
> to match our style of .py files being executable (even if we run them via
> $(PYTHON)).

Good call. I also switched the shebang from /bin/python to the
commonly use /usr/bin/python.

I pushed the patch with the mentioned modifications.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]