[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] python: add python binding for virDomainGetBlkioParameters



On 27.07.2011 04:13, Hu Tao wrote:
---
  python/libvirt-override-api.xml |    6 +-
  python/libvirt-override.c       |   79 +++++++++++++++++++++++++++++++++++++-
  2 files changed, 79 insertions(+), 6 deletions(-)

ACK

It actually exposed we need this update:

diff --git a/src/libvirt.c b/src/libvirt.c
index eeaf0b6..2ce391c 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -3516,7 +3516,7 @@ error:
  * @params: pointer to blkio parameter object
  *          (return value, allocated by the caller)
  * @nparams: pointer to number of blkio parameters
- * @flags: currently unused, for future extension
+ * @flags: an OR'ed set of virDomainModificationImpact
  *
* Get all blkio parameters, the @params array will be filled with the values
  * equal to the number of parameters suggested by @nparams.


But that will better be a follow up patch.
Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]