Re: [libvirt] [PATCH] freebsd: Add gnulib environ module for the commandtest

[Matthias Bolte <matthias bolte googlemail com>]

2011/7/28 Eric Blake <eblake redhat com>:
> On 07/28/2011 05:08 AM, Matthias Bolte wrote:
>>
>> ---
>>  bootstrap.conf |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/bootstrap.conf b/bootstrap.conf
>> index f006a47..3b105b1 100644
>> --- a/bootstrap.conf
>> +++ b/bootstrap.conf
>> @@ -36,6 +36,7 @@ configmake
>>  count-one-bits
>>  crypto/md5
>>  dirname-lgpl
>> +environ
>
> ACK.
>
> POSIX is clear that 'environ' is not declared by any standard header unless
> you use vendor extensions, whereas the gnulib module 'environ' guarantees
> the declaration in <unistd.h> to match the glibc extension when _GNU_SOURCE
> is defined (that is, the gnulib module is the vendor extension that we need
> to get the declaration visible on BSD).
>

At least all tests compile on FreeBSD again. But most of the SSH cases
in virnetmessagetest are failing and I don't understand why yet.

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com