[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] freebsd: Avoid /bin/true in commandtest



2011/7/28 Eric Blake <eblake redhat com>:
> On 07/28/2011 09:52 AM, Matthias Bolte wrote:
>>
>> Rely on PATH and use just true, because on FreeBSD it's /usr/bin/true.
>
> What fun.  The autoconf manual has this gem under true, apropos to the
> current patch:
>
> | when asked whether false is more portable than true Alexandre Oliva
> answered:
> |
> |     In a sense, yes, because if it doesn't exist, the shell will produce
> an exit status of failure, which is correct for false, but not for true.
>
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Limitations-of-Builtins
>
>> ---
>>  tests/commanddata/test16.log |    2 +-
>>  tests/commandtest.c          |    6 +++---
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> ACK.

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]