[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: avoid null pointer dereference



On 05/03/2011 10:49 AM, Daniel P. Berrange wrote:
> On Tue, May 03, 2011 at 10:45:36AM -0600, Eric Blake wrote:
>> Clang detected that vol-download will call unlink(NULL) if there
>> is a parse error during option parsing.  Also, mingw doesn't like
>> unlinking an open file.
>>
>> * tools/virsh.c (cmdVolDownload): Only unlink file if created.
>> ---
>>  tools/virsh.c |    9 +++++----
>>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]