[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: remove dead assignment



On 05/03/2011 04:29 PM, Eric Blake wrote:
Clang complained about this, and it was easy enough to fix.

* src/util/util.c (virFileOpenAs): Drop dead assignment.
---
  src/util/util.c |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/util/util.c b/src/util/util.c
index 37472bb..9041ab6 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1523,8 +1523,7 @@ virFileOpenAs(const char *path, int openflags, mode_t mode,
          if (ret<  0&&  errno != EACCES) {
              ret = -errno;
              VIR_FORCE_CLOSE(pair[0]);
-            while ((waitret = waitpid(pid, NULL, 0) == -1)
-&&  (errno == EINTR));
+            while (waitpid(pid, NULL, 0) == -1&&  errno == EINTR);
              goto parenterror;
          } else {
              fd = ret;

ACK.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]