[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/8] virDomainGetState public API



On 05/04/2011 08:45 AM, Jiri Denemark wrote:
> This API is supposed to replace virDomainGetInfo when the only purpose
> of calling it is getting current domain status.
> @@ -674,6 +726,9 @@ int                     virDomainCoreDump       (virDomainPtr domain,
>   */
>  int                     virDomainGetInfo        (virDomainPtr domain,
>                                                   virDomainInfoPtr info);
> +int                     virDomainGetState       (virDomainPtr domain,
> +                                                 int *state,
> +                                                 int *reason);

Definitely add the unsigned int flags argument.  I'm not sure yet
whether we want to pass a struct instead of two int* arguments; if
nothing else, a flag could let us treat the argument as a union of
different structs, and return a different struct of information
according to which flag was requested.

> +++ b/src/libvirt_public.syms
> @@ -436,4 +436,9 @@ LIBVIRT_0.9.0 {
>          virStorageVolUpload;
>  } LIBVIRT_0.8.8;
>  
> +LIBVIRT_0.9.1 {

0.9.2

> +    global:
> +        virDomainGetState;
> +} LIBVIRT_0.9.0;
> +
>  # .... define new API here using predicted next version number ....

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]