[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rm daemon/remote_dispatch_table.h



On Thu, May 05, 2011 at 08:07:49AM +0200, Matthias Bolte wrote:
> 2011/5/5 Hu Tao <hutao cn fujitsu com>:
> > 1. this file is automatically generated at compile-time, so rm it
> >   to avoid further commit to this file.
> > 2. any update should made to file src/remote/remote_protocol.x.
> > ---
> >  daemon/remote_dispatch_table.h | 1054 ----------------------------------------
> >  1 files changed, 0 insertions(+), 1054 deletions(-)
> >  delete mode 100644 daemon/remote_dispatch_table.h
> >
> 
> There is probably a reason why this generated file is under version
> control, maybe Dan knows.
> 
> If we decide to remove the generated protocol dispatch header files
> then we should remove all of them (daemon/remote_dispatch_*.h and
> daemon/qemu_dispatch_*.h) and not just this single one.

:( doesn't noticed other daemon/remote_dispatch_*.h are also generated
ones. Thanks for pointing it out.

Dan, what's your opinion?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]