[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: avoid comparisons to bool constants



On 05/06/2011 12:42 AM, Matthias Bolte wrote:
> 2011/5/5 Eric Blake <eblake redhat com>:
>> HACKING already mentions that comparisons against literal 'true'
>> are unsafe; for consistency, also shorten comparisons against 'false'.
>>
>> * src/conf/domain_conf.c (virDomainNetDefParseXML): Simplify.
>> * src/nwfilter/nwfilter_gentech_driver.c
>> (virNWFilterDomainFWUpdateCB): Likewise.
>> * tools/virsh.c (cmdVolDownload, vshCommandRun, vshPrintExtra):
>> Likewise.
>> ---
>>  src/conf/domain_conf.c                 |    2 +-
>>  src/nwfilter/nwfilter_gentech_driver.c |    2 +-
>>  tools/virsh.c                          |    8 ++++----
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]