[libvirt] [PATCHv2 6/3] build: rebuild generated files after rpcgen_fix.pl tweak

Eric Blake eblake at redhat.com
Fri May 6 23:34:58 UTC 2011


Noticed this while trying to run rpcgen on cygwin.

* src/Makefile.am ($(srcdir)/remote/%_protocol.h)
($(srcdir)/remote/%_protocol.c): Add a dependency.
---

Cygwin still needs rpcgen_fix.pl to do stuff, since right now
it has LOADS of warnings, then dies with:

remote/remote_protocol.c: In function 'xdr_remote_node_get_cells_free_memory_arg
s':
remote/remote_protocol.c:656: warning: unused variable 'buf' [-Wunused-variable]
remote/remote_protocol.c: In function 'xdr_remote_node_get_cells_free_memory_ret
':
remote/remote_protocol.c:671: error: 'xdr_quad_t' undeclared (first use in this function)

Unfortunately, I've run out of time to complete the fix today,
but at a first pass, I fixed the Makefile dependencies.

 src/Makefile.am |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index cea3d39..75ece49 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -552,11 +552,12 @@ libvirt_driver_remote_la_SOURCES = $(REMOTE_DRIVER_SOURCES)
 $(srcdir)/remote/remote_driver.c: $(REMOTE_DRIVER_GENERATED)

 $(srcdir)/remote/%_protocol.c: $(srcdir)/remote/%_protocol.x \
-		$(srcdir)/remote/%_protocol.h
+		$(srcdir)/remote/%_protocol.h $(srcdir)/remote/rpcgen_fix.pl
 	$(AM_V_GEN)perl -w $(srcdir)/remote/rpcgen_fix.pl $(RPCGEN) -c \
 	       $< $@

-$(srcdir)/remote/%_protocol.h: $(srcdir)/remote/%_protocol.x
+$(srcdir)/remote/%_protocol.h: $(srcdir)/remote/%_protocol.x \
+		$(srcdir)/remote/rpcgen_fix.pl
 	$(AM_V_GEN)perl -w $(srcdir)/remote/rpcgen_fix.pl $(RPCGEN) -h \
 	       $< $@

-- 
1.7.4.4




More information about the libvir-list mailing list