Re: [libvirt] Magic error introduced by commit f09accc

[Jiri Denemark <jdenemar redhat com>]

On Fri, May 06, 2011 at 16:33:13 -0600, Eric Blake wrote:
> On 05/06/2011 01:18 PM, Jiri Denemark wrote:
> We discussed more on IRC.  The problem is due to a bug in out-of-the-box
> libnl headers, and has been patched in most distros to just delete the
> 'inline' as then you don't have to worry about whether you had old or
> new gcc semantics for 'extern inline'.  That is, libvirt could probably
> work around the issue by doing:
> 
> #define inline
> #include <netlink/msg.h>
> #undef inline
> 
> in src/util/macvtap.c.
> 
> However, I don't know if we should do that.

I think we shouldn't do this.

> In one regards, the only people that ever run into this are those that are
> using incompatible self-built gcc and libnl (Jirka was testing on a gentoo
> system), and we're doing the user a favor to have them patch their libnl
> headers rather than making libvirt work around it.  Most distros (including
> RHEL 5, which stands as the current litmus test of how much workarounds we
> have to support in libvirt) have already patched the header

And I filed a BZ for gentoo as well:
http://bugs.gentoo.org/show_bug.cgi?id=366561

Jirka