[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball



On 05/09/2011 08:45 AM, Doug Goldstein wrote:
>>>  EXTRA_DIST = \
>>>    ChangeLog-old \
>>> -  libvirt.spec libvirt.spec.in \
>>> +  libvirt.spec.in \
>>
>>  Actually that part is wrong. The libvirt.spec need to be in the
>> tarball to allow to build rpms from it. This breaks for example "make rpm".
>>
>>  I reverted that part of the patch,

At least that's safe - libvirt.spec.in only substitutes @VERSION@, which
is one of the few strings where ./configure settings won't affect what
gets substituted.  That is, libvirt.spec changes only when you change
configure.ac to bump the version number, so it is safe enough to leave
under version control as well as part of the tarball.

> Since the Makefile doesn't ship in the tarball but only Makefile.in,
> which requires "./configure" be run before "make rpm" be run, that
> would mean that you don't need the libvirt.spec to be shipped in the
> tarball and you only want libvirt.spec.in and once you run ./configure
> it'll generate libvirt.spec. So in fact reverting that change is
> incorrect.
> 
> Unless of course I'm missing something.

You (and I) missed the fact that 'rpmbuild -ta libvirt-0.9.1.tar.gz' is
able to build an rpm from the tarball, only if the tarball already
contains a file named libvirt.spec.  So Dan is right that libvirt.spec
should belong to the tarball, even if it is generated by config.status.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]