[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove all generated RPC files from GIT



On Mon, May 09, 2011 at 12:51:24PM -0600, Eric Blake wrote:
> On 05/09/2011 03:21 AM, Daniel P. Berrange wrote:
> >>> +my $fixup = $^O eq "linux";
> >>
> >> I guess I'll see what happens when I try this on Cygwin, but if there
> >> are any followups needed, it should be separate patches.  As is, cygwin
> >> already can't use -Werror because of repetitive  declarations in the
> >> tirpc headers that trigger one of our default set of gcc warnings.
> > 
> > This shouldn't make Cygwin any worse should it ?  We don't support
> > running bootstrap on Win32 at all, only building from a dist. So
> > they'd not be running rpcgen
> 
> Why not?  Prior to this patch, there was nothing that prevented me from
> building libvirt.git on cygwin, and if it's not too hard to keep it that
> way, I don't see why we would want to insist that cygwin is a
> tarball-only build platform.

I didn't know that was possible. I thought we already only supported
it as a tarball build, not git


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]