Re: [libvirt] [PATCH v3 1/8] screenshot: Defining the public API

[Matthias Bolte <matthias bolte googlemail com>]

2011/5/10 Michal Privoznik <mprivozn redhat com>:
> Add public API for taking screenshots of current domain console.
>
> * include/libvirt/libvirt.h.in: add virDomainScreenshot
> * src/libvirt_public.syms: Export new symbol
> ---
>  include/libvirt/libvirt.h.in |    7 +++++++
>  src/libvirt_public.syms      |    5 +++++
>  2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 5783303..0113629 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -670,6 +670,13 @@ int                     virDomainCoreDump       (virDomainPtr domain,
>                                                  int flags);
>
>  /*
> + * Screenshot of current domain console
> + */
> +char *                  virDomainScreenshot     (virDomainPtr domain,
> +                                                 virStreamPtr stream,
> +                                                 unsigned int flags);
> +
> +/*

How do intent to handle multi-head domains here? The domain XML video
element has a heads argument and for example VirtualBox supports it.
Do we only support taking screenshots of the first monitor or do we
take an aggregated screenshot overall monitors?

> diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
> index b4aed41..5c9e6b4 100644
> --- a/src/libvirt_public.syms
> +++ b/src/libvirt_public.syms
> @@ -436,4 +436,9 @@ LIBVIRT_0.9.0 {
>         virStorageVolUpload;
>  } LIBVIRT_0.8.8;
>
> +LIBVIRT_0.9.1 {
> +    global:
> +        virDomainScreenshot;
> +} LIBVIRT_0.9.0;
> +

0.9.1 is already released so this should be 0.9.2 here.

Matthias