[libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

Richard W.M. Jones rjones at redhat.com
Tue May 10 16:17:12 UTC 2011


On Tue, May 10, 2011 at 04:32:57PM +0100, Daniel P. Berrange wrote:
> Yeah, either we duplicate the VIR_CONNECT_RO flag checks in
> the remote dispatch, or we could actually generate the libvirt.c
> and driver.h files too, based on the RPC.

<advocacy>

More code generation is better.  Here is all the code you need to
write to make a new libguestfs API function:

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=4ffa2d6798f7a2bf0baec8e1084659cf6358bc31

That's not a printing error, it really is just 38 lines of code.

>From that template we generate:

  - RPC stubs similar to libvirt remote driver
  - bindings in around 8 programming languages
  - <guestfs.h> header file
  - several manual pages, eg: http://libguestfs.org/guestfs.3.html#api_calls
  - guestfish
  - part of the automated tests

This is a huge time saver, and reduces bugs.

</advocacy>

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora




More information about the libvir-list mailing list