[libvirt] [PATCH 00/16] More virCommand conversions and cleanups

Cole Robinson crobinso at redhat.com
Tue May 10 20:07:39 UTC 2011


The following series converts all users of several older command
wrappers (virRunWithHook, virExecDaemonize, and virExec) to use
virCommand. The remaining functionality is then moved out of
util.c and into command.c

Cole Robinson (16):
  remote_driver: Convert virExecDaemonize usage to virCommand
  util: Combine __virExec and virExecWithHook
  command: Allow setting a NULL hook function
  storage_backend: Convert virRunWithHook usage to virCommand
  apparmor: Convert virExec usage to virCommand
  storage: Convert qemu-img -help parsing to virCommand
  storage: Covert regex helpers to virCommand
  storage: iscsi: Convert virExec to virCommand
  qemu: Convert virExec usage to virCommand
  openvz: Convert virExec usage to virCommand
  remote: Convert SSH tunnel to virCommand
  util: Remove unused virExec wrapper
  util: Implement virRun as a wrapper around virCommand
  Move virRun, virExec*, virFork to util/command
  storage_backend: Fix error reporting with regex helper
  command: Report stdout/stderr if command fails

 cfg.mk                                    |    2 +-
 src/libvirt_private.syms                  |    8 +-
 src/lxc/veth.c                            |    2 +-
 src/nwfilter/nwfilter_ebiptables_driver.c |    1 +
 src/openvz/openvz_conf.c                  |   37 +-
 src/openvz/openvz_driver.c                |   52 ++-
 src/qemu/qemu_driver.c                    |   14 +-
 src/qemu/qemu_process.c                   |    2 +-
 src/remote/remote_driver.c                |   83 +--
 src/security/security_apparmor.c          |   70 +---
 src/storage/storage_backend.c             |  292 ++++--------
 src/storage/storage_backend.h             |    3 +-
 src/storage/storage_backend_fs.c          |    7 +-
 src/storage/storage_backend_iscsi.c       |   40 +-
 src/storage/storage_backend_logical.c     |   32 +-
 src/util/command.c                        |  621 +++++++++++++++++++++++-
 src/util/command.h                        |   16 +-
 src/util/ebtables.c                       |    2 +-
 src/util/pci.c                            |    2 +-
 src/util/util.c                           |  764 +----------------------------
 src/util/util.h                           |   44 --
 src/vmware/vmware_driver.c                |    1 +
 22 files changed, 854 insertions(+), 1241 deletions(-)

-- 
1.7.4.4




More information about the libvir-list mailing list