[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces



On 05/10/2011 05:59 AM, D. Herrendoerfer wrote:
> Hi all,
> 
> starting with kernel 2.6.38 macvtap supports a 'passthru' mode for
> attaching virtual functions
> of a SRIOV capable network card directly to a VM.
> This patch adds the capability to configure such a device.
> 
> Signed-off-by: Dirk Herrendoerfer <d.herrendoerfer at herrendoerfer.name>
> 
> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
> index 7163c6e..e2a66ae 100644
> --- a/docs/schemas/domain.rng
> +++ b/docs/schemas/domain.rng
> @@ -2351,7 +2351,7 @@
>    </define>
>    <define name="bridgeMode">
>      <data type="string">
> -      <param name="pattern">(vepa|bridge|private)</param>
> +      <param name="pattern">(vepa|bridge|private|passthru)</param>
>      </data>
>    </define>
>    <define name="addrMAC">

Missing corresponding documentation in docs/formatdomain.html.in to
describe the new mode.

What happens if you try to use this mode but you have an older kernel?
Do we need to add any sanity checking to give a saner error message than
just blindly trying the string and reporting back whatever message gets
returned about an unknown argument?

The rest of this patch looks okay to me (with my disclaimer that I've
never used an SRIOV card), but I'd rather wait for a v2 than push this
without documentation.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]