Re: [libvirt] [PATCH 2/2] Don't kill QEMU process when a monitor I/O parsing error occurs

[Dan Kenigsberg <danken redhat com>]

On Wed, May 11, 2011 at 12:59:07PM +0100, Daniel P. Berrange wrote:
>
>  
> +/*
> + * This is invoked when there is some kind of error
> + * parsing data to/from the monitor. The VM can continue
> + * to run, but no further monitor commands will be
> + * allowed
> + */
> +static void
> +qemuProcessHandleMonitorError(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
> +                              virDomainObjPtr vm)

I'm all for being graceful and polite, so this sounds good.

However, events are bound to be lost. The solution would be more robust
if there was a way to query the state of the monitor (though I'm not
sure it is worth the hassle).

PS, I wonder what VMM stands for in this context. Not virtual memory
manager, I suppose.

Since I've only read the comments, not the code, I wonder if the 'quit'
command is still passed to the monitro even after an error occured.
Without it, we'd have to resort to SIGTERM/SIGKILL, which is less
graceful.