[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration



Hi Eric,
thank you for the quick and detailed patch review!
I think I fixed all the problems that you described but if you find
anything that I missed or anything new I'll be happy to accept the
help you offered :)
You can update my email address in AUTHORS to the redhat one.

commit a0ca40ce07f6c54901aac4e32bcfd573980bd38f
Author: Federico Simoncelli <fsimonce redhat com>
Date:   Tue May 10 11:36:48 2011 +0100

    qemu: allow blkstat/blkinfo calls during migration
    
    Originally most of libvirt domain-specific calls were blocking
    during a migration.
    A new mechanism to allow specific calls (blkstat/blkinfo) to be
    executed in such condition has been implemented.
    In the long term it'd be desirable to get a more general
    solution to mark further APIs as migration safe, without needing
    special case code.
    
     * src/qemu/qemu_migration.c: add some additional job signal
       flags for doing blkstat/blkinfo during a migration
     * src/qemu/qemu_domain.c: add a condition variable that can be
       used to efficiently wait for the migration code to clear the
       signal flag
     * src/qemu/qemu_driver.c: execute blkstat/blkinfo using the
       job signal flags during migration
---
 src/qemu/qemu_domain.c    |    6 +++
 src/qemu/qemu_domain.h    |    9 ++++
 src/qemu/qemu_driver.c    |  103 ++++++++++++++++++++++++++++++++-------------
 src/qemu/qemu_migration.c |   35 +++++++++++++++
 4 files changed, 123 insertions(+), 30 deletions(-)

-- 
Federico.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]