[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/16] Refactor tunnelled migration methods



On 05/11/2011 03:09 AM, Daniel P. Berrange wrote:
> To facilitate the introduction of the v3 migration protocol,
> the doTunnelMigrate method is refactored into two pieces. One
> piece is intended to mirror the flow of virDomainMigrateVersion2,
> while the other is the helper for setting up sockets and processing
> the data.
> 
> Previously socket setup would be done before the 'prepare' step,
> so errors could be dealt with immediately, avoiding need to shut
> off the destination QEMU. In the new split, socket setup is done
> after the 'prepare' step. This is not a serious problem, since
> the control flow already requires calling 'finish' to tear down
> the destination QEMU upon several errors.
> 
> * src/qemu/qemu_migration.c:
> ---
>  src/qemu/qemu_migration.c |  159 ++++++++++++++++++++++-----------------------
>  1 files changed, 78 insertions(+), 81 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]