[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/9] Internal driver API for virDomainGetState



On Tue, May 10, 2011 at 03:39:04PM +0200, Jiri Denemark wrote:
> ---
> Notes:
>     Version 2:
>     - rebased
>     - unsigned int flags parameter
>     - avoid changing xenUnifiedDriver internal callback struct
> 
>  src/driver.h               |    6 ++++++
>  src/esx/esx_driver.c       |    1 +
>  src/libxl/libxl_driver.c   |    1 +
>  src/lxc/lxc_driver.c       |    1 +
>  src/openvz/openvz_driver.c |    1 +
>  src/phyp/phyp_driver.c     |    1 +
>  src/qemu/qemu_driver.c     |    1 +
>  src/remote/remote_driver.c |    1 +
>  src/test/test_driver.c     |    1 +
>  src/uml/uml_driver.c       |    1 +
>  src/vbox/vbox_tmpl.c       |    1 +
>  src/vmware/vmware_driver.c |    1 +
>  src/xen/xen_driver.c       |    1 +
>  src/xenapi/xenapi_driver.c |    1 +
>  14 files changed, 19 insertions(+), 0 deletions(-)
> 
> diff --git a/src/driver.h b/src/driver.h
> index a8b79e6..ed9846a 100644
> --- a/src/driver.h
> +++ b/src/driver.h
> @@ -166,6 +166,11 @@ typedef int
>          (*virDrvDomainGetInfo)		(virDomainPtr domain,
>                                           virDomainInfoPtr info);
>  typedef int
> +        (*virDrvDomainGetState)         (virDomainPtr domain,
> +                                         int *state,
> +                                         int *reason,
> +                                         unsigned int flags);
> +typedef int
>          (*virDrvDomainSave)		(virDomainPtr domain,
>                                           const char *to);
>  typedef int
> @@ -563,6 +568,7 @@ struct _virDriver {
>      virDrvDomainSetBlkioParameters domainSetBlkioParameters;
>      virDrvDomainGetBlkioParameters domainGetBlkioParameters;
>      virDrvDomainGetInfo		domainGetInfo;
> +    virDrvDomainGetState	domainGetState;
>      virDrvDomainSave		domainSave;
>      virDrvDomainRestore		domainRestore;
>      virDrvDomainCoreDump		domainCoreDump;
> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
> index 7933f11..ec2aaf9 100644
> --- a/src/esx/esx_driver.c
> +++ b/src/esx/esx_driver.c
> @@ -4623,6 +4623,7 @@ static virDriver esxDriver = {
>      NULL,                            /* domainSetBlkioParameters */
>      NULL,                            /* domainGetBlkioParameters */
>      esxDomainGetInfo,                /* domainGetInfo */
> +    NULL,                            /* domainGetState */
>      NULL,                            /* domainSave */
>      NULL,                            /* domainRestore */
>      NULL,                            /* domainCoreDump */
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index a2c8467..794a9e7 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -2714,6 +2714,7 @@ static virDriver libxlDriver = {
>      NULL,                       /* domainSetBlkioParameters */
>      NULL,                       /* domainGetBlkioParameters */
>      libxlDomainGetInfo,         /* domainGetInfo */
> +    NULL,                       /* domainGetState */
>      NULL,                       /* domainSave */
>      NULL,                       /* domainRestore */
>      NULL,                       /* domainCoreDump */
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index b94941d..0dcaf4c 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -2829,6 +2829,7 @@ static virDriver lxcDriver = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      lxcDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      NULL, /* domainSave */
>      NULL, /* domainRestore */
>      NULL, /* domainCoreDump */
> diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
> index 0bd007a..48a3aae 100644
> --- a/src/openvz/openvz_driver.c
> +++ b/src/openvz/openvz_driver.c
> @@ -1591,6 +1591,7 @@ static virDriver openvzDriver = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      openvzDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      NULL, /* domainSave */
>      NULL, /* domainRestore */
>      NULL, /* domainCoreDump */
> diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
> index 30d4adf..abd3594 100644
> --- a/src/phyp/phyp_driver.c
> +++ b/src/phyp/phyp_driver.c
> @@ -3752,6 +3752,7 @@ static virDriver phypDriver = {
>      NULL,                       /* domainSetBlkioParameters */
>      NULL,                       /* domainGetBlkioParameters */
>      phypDomainGetInfo,          /* domainGetInfo */
> +    NULL,                       /* domainGetState */
>      NULL,                       /* domainSave */
>      NULL,                       /* domainRestore */
>      NULL,                       /* domainCoreDump */
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 0fd0f10..92c7f9a 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -7116,6 +7116,7 @@ static virDriver qemuDriver = {
>      qemuDomainSetBlkioParameters, /* domainSetBlkioParameters */
>      qemuDomainGetBlkioParameters, /* domainGetBlkioParameters */
>      qemudDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      qemudDomainSave, /* domainSave */
>      qemuDomainRestore, /* domainRestore */
>      qemudDomainCoreDump, /* domainCoreDump */
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index d076a90..90d95d6 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -6417,6 +6417,7 @@ static virDriver remote_driver = {
>      remoteDomainSetBlkioParameters, /* domainSetBlkioParameters */
>      remoteDomainGetBlkioParameters, /* domainGetBlkioParameters */
>      remoteDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      remoteDomainSave, /* domainSave */
>      remoteDomainRestore, /* domainRestore */
>      remoteDomainCoreDump, /* domainCoreDump */
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index 0978214..6f4ae75 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -5371,6 +5371,7 @@ static virDriver testDriver = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      testGetDomainInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      testDomainSave, /* domainSave */
>      testDomainRestore, /* domainRestore */
>      testDomainCoreDump, /* domainCoreDump */
> diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
> index 33849a0..6852a16 100644
> --- a/src/uml/uml_driver.c
> +++ b/src/uml/uml_driver.c
> @@ -2177,6 +2177,7 @@ static virDriver umlDriver = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      umlDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      NULL, /* domainSave */
>      NULL, /* domainRestore */
>      NULL, /* domainCoreDump */
> diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> index 8241d34..d4a8924 100644
> --- a/src/vbox/vbox_tmpl.c
> +++ b/src/vbox/vbox_tmpl.c
> @@ -8566,6 +8566,7 @@ virDriver NAME(Driver) = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      vboxDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      vboxDomainSave, /* domainSave */
>      NULL, /* domainRestore */
>      NULL, /* domainCoreDump */
> diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c
> index bbfb1a4..c6c92c6 100644
> --- a/src/vmware/vmware_driver.c
> +++ b/src/vmware/vmware_driver.c
> @@ -931,6 +931,7 @@ static virDriver vmwareDriver = {
>      NULL,                       /* domainSetBlkioParameters */
>      NULL,                       /* domainGetBlkioParameters */
>      vmwareDomainGetInfo,        /* domainGetInfo */
> +    NULL,                       /* domainGetState */
>      NULL,                       /* domainSave */
>      NULL,                       /* domainRestore */
>      NULL,                       /* domainCoreDump */
> diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
> index dd94fbc..1646828 100644
> --- a/src/xen/xen_driver.c
> +++ b/src/xen/xen_driver.c
> @@ -2132,6 +2132,7 @@ static virDriver xenUnifiedDriver = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      xenUnifiedDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      xenUnifiedDomainSave, /* domainSave */
>      xenUnifiedDomainRestore, /* domainRestore */
>      xenUnifiedDomainCoreDump, /* domainCoreDump */
> diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
> index 3fbdcc6..83417df 100644
> --- a/src/xenapi/xenapi_driver.c
> +++ b/src/xenapi/xenapi_driver.c
> @@ -1813,6 +1813,7 @@ static virDriver xenapiDriver = {
>      NULL, /* domainSetBlkioParameters */
>      NULL, /* domainGetBlkioParameters */
>      xenapiDomainGetInfo, /* domainGetInfo */
> +    NULL, /* domainGetState */
>      NULL, /* domainSave */
>      NULL, /* domainRestore */
>      NULL, /* domainCoreDump */

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]