[libvirt] [PATCH 0/9 v2] More virCommand conversions and cleanups

Cole Robinson crobinso at redhat.com
Fri May 13 20:10:28 UTC 2011


The following series converts all users of several older command
wrappers (virRunWithHook, virExecDaemonize, and virExec) to use
virCommand. The remaining functionality is then moved out of
util.c and into command.c

v2:
    Committed some patches
    Dropped final patch, can be submitted seperately
    Addressed Eric's comments

Cole Robinson (9):
  storage: iscsi: Convert virExec to virCommand
  openvz: Convert virExec usage to virCommand
  qemu: Convert virExec usage to virCommand
  storage: Covert regex helpers to virCommand
  storage_backend: Fix error reporting with regex helper
  storage_backend: Convert virRunWithHook usage to virCommand
  util: Remove unused virExec wrapper
  util: Implement virRun as a wrapper around virCommand
  Move virRun, virExec*, virFork to util/command

 cfg.mk                                    |    2 +-
 src/libvirt_private.syms                  |    7 +-
 src/lxc/veth.c                            |    2 +-
 src/nwfilter/nwfilter_ebiptables_driver.c |    1 +
 src/openvz/openvz_conf.c                  |   37 +-
 src/openvz/openvz_driver.c                |   55 ++--
 src/qemu/qemu_driver.c                    |   35 +-
 src/qemu/qemu_process.c                   |    2 +-
 src/storage/storage_backend.c             |  262 ++++--------
 src/storage/storage_backend.h             |    3 +-
 src/storage/storage_backend_fs.c          |    7 +-
 src/storage/storage_backend_iscsi.c       |   39 +--
 src/storage/storage_backend_logical.c     |   32 +--
 src/util/command.c                        |  568 ++++++++++++++++++++++++
 src/util/command.h                        |   14 +
 src/util/ebtables.c                       |    2 +-
 src/util/pci.c                            |    2 +-
 src/util/util.c                           |  674 +----------------------------
 src/util/util.h                           |   35 --
 src/vmware/vmware_driver.c                |    1 +
 20 files changed, 765 insertions(+), 1015 deletions(-)

-- 
1.7.4.4




More information about the libvir-list mailing list