[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/9] util: Remove unused virExec wrapper



On 05/13/2011 02:10 PM, Cole Robinson wrote:
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/libvirt_private.syms |    1 -
>  src/util/util.c          |   35 -----------------------------------
>  src/util/util.h          |    8 --------
>  3 files changed, 0 insertions(+), 44 deletions(-)

Oops - division by zero when I tried to continue my trend of pointing
out the nice patch ratio in this series :)

And in spite of that, I still found a problem with it - you didn't
delete enough :-)

ACK with this squashed in:

diff --git i/cfg.mk w/cfg.mk
index 06b638b..eba4462 100644
--- i/cfg.mk
+++ w/cfg.mk
@@ -261,7 +261,6 @@ sc_prohibit_close:
 	  $(_sc_search_regexp)

 # Prefer virCommand for all child processes.
-# XXX - eventually, we want to enhance this to also prohibit virExec.
 sc_prohibit_fork_wrappers:
 	@prohibit='= *\<(fork|popen|system) *\('			\
 	halt='use virCommand for child processes'			\


-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]