[libvirt] [PATCH] command: Fix compilation on FreeBSD
Matthias Bolte
matthias.bolte at googlemail.com
Sat May 14 05:01:06 UTC 2011
2011/5/13 Eric Blake <eblake at redhat.com>:
> On 05/12/2011 11:53 PM, Matthias Bolte wrote:
>> kill, SIGTERM and SIGKILL require additional headers.
>> ---
>> src/util/command.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/util/command.c b/src/util/command.c
>> index b488d55..b2a873b 100644
>> --- a/src/util/command.c
>> +++ b/src/util/command.c
>> @@ -22,9 +22,11 @@
>> #include <config.h>
>>
>> #include <poll.h>
>> +#include <signal.h>
>
> Definitely.
>
>> #include <stdarg.h>
>> #include <stdlib.h>
>> #include <sys/stat.h>
>> +#include <sys/types.h>
>
> Spurious. Gnulib already takes care of this (if it doesn't, and you get
> a compile error due to not including <sys/types.h>, then please post
> that to the gnulib list, and I'll fix it upstream).
Actually I didn't test if sys/types.h is really necessary, I just
included what the man page said and it worked then. But you're right,
it only needs signal.h.
I'm pushing this one with the signal.h addition only.
Matthias
More information about the libvir-list
mailing list