[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] domain: Require <init> for container guests



On Fri, May 13, 2011 at 10:46:51AM -0400, Cole Robinson wrote:
> On 05/13/2011 05:27 AM, Daniel P. Berrange wrote:
> > On Thu, May 12, 2011 at 05:47:42PM -0400, Cole Robinson wrote:
> >> Use capabilities to allow a driver to register a default <init> if none
> >> is specified in the XML. Openvz was already open-coding this to be /sbin/init
> >>
> >> LXC currently falls over if no init is specified, so an explicit error is
> >> an improvement IMO.
> >>
> >> (Side note: I don't think we can set a default value for LXC. If we use
> >> /sbin/init but the user doesn't specify a separate root FS for their guest,
> >> the container will rerun the host's init which can be traumatic :). For
> >> virt-install I'm thinking of defaulting to /sbin/init if a root FS has
> >> been specified, otherwise require the user to manually specify <init>)
> > 
> > We could set '/bin/sh' as the default for non-root FS containers.
> > 
> 
> In virt-install or at the libvirt level?

I'd do it at the libvirt level

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]