[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/16] Introduce migration cookies to QEMU driver



On 05/16/2011 08:00 AM, Daniel P. Berrange wrote:
>>>> @@ -369,7 +648,7 @@ cleanup:
>>>>          virDomainObjUnlock(vm);
>>>>      if (event)
>>>>          qemuDomainEventQueue(driver, event);
>>>> -    qemuDriverUnlock(driver);
>>>> +    qemuMigrationCookieFree(mig);
>>>
>>> Umm, did you really intend to drop the qemuDriverUnlock line?
>>
>> No, that's a merge rebase error
> 
> Actually no it wasn't. This is a bug that's being fixed. The caller of
> this method, already unlocks the driver on completion, so we had a
> double unlock.

Then let's split that into a separate patch; bug fixes and new features
in the same patch are harder to deal with during bisection.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]