[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] Automatically generate the hvsupport.html.in file from source files



On 05/16/2011 10:11 AM, Daniel P. Berrange wrote:
> On Mon, May 16, 2011 at 10:00:30AM -0600, Eric Blake wrote:
>> On 05/13/2011 07:36 AM, Daniel P. Berrange wrote:
>>> The hvsupport.html.in file is forever out of date. By annotating
>>> the driver struct tables in each driver with version information,
>>> we can auto-generate the hvsupport.html.in file. Annotating the
>>> drivers will be mandatory for new patches, ensuring hvsupport.html.in
>>> is never out of date again.
>>>
>>> * docs/hvsupport.html.in: Delete
>>> * hvsupport.pl: Script to generate hvsupport.html.in
>>> * Makefile.am: Autogenerate hvsupport.html.in
>>> ---
>>>  docs/Makefile.am       |   10 +-
>>>  docs/hvsupport.html.in |  801 ------------------------------------------------
>>>  docs/hvsupport.pl      |  353 +++++++++++++++++++++
>>>  3 files changed, 360 insertions(+), 804 deletions(-)
>>>  delete mode 100644 docs/hvsupport.html.in
>>>  create mode 100644 docs/hvsupport.pl
>>
>> Hmm, that should probably be mode 100755, since it is an executable
>> script.  I'm pushing that obvious fix.
> 
> It doesn't hugely matter, since the makefile.am explicitly
> calls '$(PERL) hvsupport.pl'

True, but we might as well be consistent:

-rwxrwxr-x. 1 dummy dummy 45492 May 12 09:56 ./daemon/remote_generator.pl*
-rw-rw-r--. 1 dummy dummy  9521 May 16 09:23 ./docs/hvsupport.pl
-rwxrwxr-x. 1 dummy dummy  3290 Mar 14 14:36 ./docs/todo.pl*
-rw-rw-r--. 1 dummy dummy  3083 May  9 10:14 ./src/remote/rpcgen_fix.pl
-rw-rw-r--. 1 dummy dummy   688 Nov  1  2010 ./tests/oomtrace.pl

Before-hand, 2 out of 5 had the bit set; yet tests/oomtrace.pl is _not_
invoked via $(PERL) in tests/Makefile.am.  So now all 5 scripts have the
bit set.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]