[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] remote generator, client: Handle functions that return an optional string



On 05/15/2011 12:23 AM, Matthias Bolte wrote:
> ---
>  daemon/remote_generator.pl   |    5 +++++
>  src/remote/remote_driver.c   |   26 --------------------------
>  src/remote/remote_protocol.x |    2 +-
>  3 files changed, 6 insertions(+), 27 deletions(-)

To test this, I installed the patch, and compared
src/remote/remote_client_bodies.h with the hand-maintained code being
removed; the only differences were in whitespace or trivial declaration
reordering.

ACK.

> +++ b/src/remote/remote_protocol.x
> @@ -2091,7 +2091,7 @@ enum remote_procedure {
>      REMOTE_PROC_NODE_LIST_DEVICES = 112, /* autogen autogen */
>      REMOTE_PROC_NODE_DEVICE_LOOKUP_BY_NAME = 113, /* autogen autogen */
>      REMOTE_PROC_NODE_DEVICE_GET_XML_DESC = 114, /* autogen autogen */
> -    REMOTE_PROC_NODE_DEVICE_GET_PARENT = 115, /* skipgen skipgen */
> +    REMOTE_PROC_NODE_DEVICE_GET_PARENT = 115, /* skipgen autogen */
>      REMOTE_PROC_NODE_DEVICE_NUM_OF_CAPS = 116, /* autogen autogen */
>      REMOTE_PROC_NODE_DEVICE_LIST_CAPS = 117, /* autogen autogen */
>      REMOTE_PROC_NODE_DEVICE_DETTACH = 118, /* autogen skipgen */

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]