[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] Clarify semantic of virDomain(G|S)et*Parameters functions



2011/5/18 Daniel Veillard <veillard redhat com>:
> On Wed, May 18, 2011 at 12:21:07PM +0200, Matthias Bolte wrote:
>> This series was inspired by the discusion about invalid argument checking
>> in the public API and the unclear semantic of this functions.
>>
>> https://www.redhat.com/archives/libvir-list/2011-May/msg01105.html
>>
>> Clarify that the getter functions don't allow to obtain a subset of the
>> parameters. You can only get all at once.
>>
>> Clarify that the setter functions can set a subset of the parameters.
>
>  ACK to the serie with small nit in 2/6 , also 6/6 looks a lot like one
> of the previous patches in the previous patch set, but seems okay to me !
>
> Daniel

Yes, 6/6 is the rest of the original patch that led to this series, I
should have denoted that.

I changed 2/6 as suggested and pushed the series.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]