[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't generate cookies with v2 migration protocol.



On 05/18/2011 11:08 AM, Daniel P. Berrange wrote:
> The v2 migration protocol had a limit on cookie length that was
> too small to be useful for QEMU. Avoid generating cookies with
> v2 protocol, so that old libvirtd can still reliably migrate a
> guest to new libvirtd uses v2 protocol.
> 
> * src/qemu/qemu_driver.c: Avoid migration cookies with v2
>   migration
> ---
>  src/qemu/qemu_driver.c |   27 ++++++++++++++++++++-------
>  1 files changed, 20 insertions(+), 7 deletions(-)

Is it any better to try generating the cookie, and only discard it if it
was too long, than to blindly skip the cookie?  Or are we pretty sure
that the cookie will always be longer than the old limit (256, if I'm
reading REMOTE_MIGRATE_COOKIE_MAX correctly in remote_protocol.x)?

If the latter, then ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]