[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 4/4] vcpupin: add the new options to "virsh vcpupin" command



On 05/20/2011 04:10 AM, Taku Izumi wrote:
> --- libvirt.orig/tools/virsh.c
> +++ libvirt/tools/virsh.c
> @@ -2757,6 +2757,9 @@ static const vshCmdOptDef opts_vcpupin[]
>      {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
>      {"vcpu", VSH_OT_INT, VSH_OFLAG_REQ, N_("vcpu number")},
>      {"cpulist", VSH_OT_DATA, VSH_OFLAG_REQ, N_("host cpu number(s) (comma separated)")},
> +    {"config", VSH_OT_BOOL, 0, N_("affect next boot")},
> +    {"live", VSH_OT_BOOL, 0, N_("affect running domain")},
> +    {"current", VSH_OT_BOOL, 0, N_("affect current domain")},

I am probably just unenlightened, but I still don't understand the
difference between 'current domain' and 'running domain'.

>      {NULL, 0, 0, NULL}
>  };
> 

<snip>

> --- libvirt.orig/tools/virsh.pod
> +++ libvirt/tools/virsh.pod
> @@ -767,10 +767,16 @@ values; these two flags cannot both be s
>  Returns basic information about the domain virtual CPUs, like the number of
>  vCPUs, the running time, the affinity to physical processors.
> 
> -=item B<vcpupin> I<domain-id> I<vcpu> I<cpulist>
> +=item B<vcpupin> I<domain-id> I<vcpu> I<cpulist> optional I<--live> I<--config>
> +I<--current>
> 
>  Pin domain VCPUs to host physical CPUs. The I<vcpu> number must be provided
>  and I<cpulist> is a comma separated list of physical CPU numbers.
> +If I<--live> is specified, affect a running guest.
> +If I<--config> is specified, affect the next boot of a persistent guest.
> +If I<--current> is specified, affect the current guest state.
> +Both I<--live> and I<--config> flags may be given, but I<--current> is exclusive.
> +If no flag is specified, behavior is different depending on hypervisor.

According to the API documentation, --current is the same as not
specifying either flag.  If that's correct, than both the default (no
flags) and --current have the same behavior (which is hypervisor
dependent).  The --current switch doesn't even seem necessary.

-- 
Adam Litke
IBM Linux Technology Center


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]