Re: [libvirt] [PATCH] Fix initialization of current vcpus in libxl driver

[Eric Blake <eblake redhat com>]

On 05/23/2011 04:26 PM, Jim Fehlig wrote:
>      b_info->hvm = hvm;
>      b_info->max_vcpus = def->maxvcpus;
> -    b_info->cur_vcpus = def->vcpus;
> +    b_info->cur_vcpus = (1 << def->vcpus) - 1;

That's a compilation pitfall if def->vcpus is exactly 32.

Shoot; xenFormatSxpr in xenxs/xen_sxpr.c has the same bug.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature