[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] qemu: fix typo in name - should be VHOST_NET, not VNET_HOST



On Tue, May 24, 2011 at 10:31:33AM -0400, Laine Stump wrote:
> NB: the enum that uses the string vnet-host (now changed to vhost-net)
> is used in XML, but fortunately that hasn't been in an official
> release yet, so it can still be fixed.
> ---
>  src/qemu/qemu_capabilities.c |    4 ++--
>  src/qemu/qemu_capabilities.h |    2 +-
>  src/qemu/qemu_command.c      |    2 +-
>  tests/qemuhelptest.c         |    8 ++++----
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 71a54a5..c69cf1d 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -85,7 +85,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
>                "netdev",
>  
>                "rtc", /* 30 */
> -              "vnet-host",
> +              "vhost-net",
>                "rtc-td-hack",
>                "no-hpet",
>                "no-kvm-pit",

NACK.  See the comment above this enum

  /* While not public, these strings must not change. They
   * are used in domain status files which are read on
   * daemon restarts
   */
  VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
                "kqemu",  /* 0 */
                "vnc-colon",
                ...

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]