Re: [libvirt] [PATCH 1/9] Extend v3 migration protocol to allow app supplied XML for target

[Matthias Bolte <matthias bolte googlemail com>]

2011/5/24 Daniel P. Berrange <berrange redhat com>:
> This extends the v3 migration protocol such that the
> virDomainMigrateBegin3 and virDomainMigratePerform3
> methods accept an application supplied XML config for
> the target VM.
>
> If the 'xmlin' parameter is NULL, then Begin3 uses the
> current guest XML as normal. A driver implementing the
> Begin3 method should either reject all non-NULL 'xmlin'
> parameters, or strictly validate that the app supplied
> XML does not change guest ABI.
>
> The Perform3 method also needed the xmlin parameter to
> cope with the Peer2Peer migration sequence.
>
> NB it is not yet possible to use this capability since
> neither of the public virDomainMigrate/virDomainMigrateToURI
> methods have a way to pass in XML.
>
> * daemon/remote.c, src/remote/remote_driver.c,
>  src/remote/remote_protocol.x, src/remote_protocol-structs:
>  Add 'remote_string xmlin' parameter to begin3/perform3
>  RPC messages
> * src/libvirt.c, src/driver.h, src/libvirt_internal.h: Add
>  'const char *xmlin' parameter to Begin3/Perform3 methods
> * src/qemu/qemu_driver.c, src/qemu/qemu_migration.c,
>  src/qemu/qemu_migration.h: Pass xmlin parameter around
>  migration methods
> ---
>  daemon/remote.c              |    8 +++++-
>  src/driver.h                 |    2 +
>  src/libvirt.c                |   49 ++++++++++++++++++++++++++++++-----------
>  src/libvirt_internal.h       |    2 +
>  src/qemu/qemu_driver.c       |    8 ++++--
>  src/qemu/qemu_migration.c    |   17 ++++++++++++--
>  src/qemu/qemu_migration.h    |    2 +
>  src/remote/remote_driver.c   |    4 +++
>  src/remote/remote_protocol.x |    2 +
>  src/remote_protocol-structs  |    2 +
>  10 files changed, 75 insertions(+), 21 deletions(-)
>

ACK.

Matthias