[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: avoid strerror_r pitfalls



On 05/24/2011 11:23 PM, Matthias Bolte wrote:
> 2011/5/25 Eric Blake <eblake redhat com>:
>> In particular, this guarantees that virStrerror always gives a
>> useful result.
>>
>> * .gnulib: Update to latest, for (lots of) strerror_r fixes.
>> ---
>>
>> This patch removes the need for Daniel's proposal:
>> https://www.redhat.com/archives/libvir-list/2011-May/msg01236.html
>>
>> Now gnulib guarantees that strerror_r will never leave garbage
>> in the buffer.

I'm impressed - I'm now up to 3 out of 3 glibc bugs reported and fixed
in the last month (more often than not, I've had the misfortune of my
glibc bugs report attempts being rejected with rather scathing comments
that the bug is not in glibc but in my understanding, or left without a
response for months on end).  Leaving garbage in buf upon strerror_r
failure was one of those fixes.

> This also pulls in the fix for the fnmatch compile warning.
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]