[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] time_t is not a long on FreeBSD, switch internal type to long long



2011/5/25 Eric Blake <eblake redhat com>:
> On 05/25/2011 09:05 AM, Matthias Bolte wrote:
>> ---
>> v2: switch internal type to long long instead of adding casts for time_t
>>
>>  src/conf/domain_conf.c |    8 ++++----
>>  src/conf/domain_conf.h |    2 +-
>>  src/esx/esx_vi_types.c |    2 +-
>>  src/esx/esx_vi_types.h |    2 +-
>>  4 files changed, 7 insertions(+), 7 deletions(-)
>
> ACK.
>

I missed to fix the test case to the
esxVI_DateTime_ConvertToCalendarTime function, so fold this in before
pushing.

diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c
index 2b36535..51c1e34 100644
--- a/tests/esxutilstest.c
+++ b/tests/esxutilstest.c
@@ -169,7 +169,7 @@ testParseDatastorePath(const void *data ATTRIBUTE_UNUSED)

 struct testDateTime {
     const char *dateTime;
-    time_t calendarTime;
+    long long calendarTime;
 };

 static struct testDateTime times[] = {
@@ -205,7 +205,7 @@ testConvertDateTimeToCalendarTime(const void *data
ATTRIBUTE_UNUSED)
 {
     int i;
     esxVI_DateTime dateTime;
-    time_t calendarTime;
+    long long calendarTime;

     for (i = 0; i < ARRAY_CARDINALITY(times); ++i) {
         dateTime.value = (char *)times[i].dateTime;

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]