Re: [libvirt] [PATCH 06/13] send-key: Defining the internal API

["Daniel P. Berrange" <berrange redhat com>]

On Wed, May 25, 2011 at 05:37:48PM +0800, Lai Jiangshan wrote:
> Signed-off-by: Lai Jiangshan <laijs fujitsu com>
> ---
>  src/driver.h |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/src/driver.h b/src/driver.h
> index 450dd53..70a30d9 100644
> --- a/src/driver.h
> +++ b/src/driver.h
> @@ -535,6 +535,13 @@ typedef int
>  typedef int
>      (*virDrvDomainInjectNMI)(virDomainPtr dom, unsigned int flags);
>  
> +typedef int
> +    (*virDrvDomainSendKey)(virDomainPtr dom, unsigned int codeset,
> +                           unsigned int holdtime,
> +                           unsigned int nkeycodes,
> +                           unsigned int *keycodes,
> +                           unsigned int flags);
> +
>  typedef char *
>      (*virDrvDomainMigrateBegin3)
>                      (virDomainPtr domain,
> @@ -738,6 +745,7 @@ struct _virDriver {
>      virDrvDomainMigratePerform3	domainMigratePerform3;
>      virDrvDomainMigrateFinish3	domainMigrateFinish3;
>      virDrvDomainMigrateConfirm3	domainMigrateConfirm3;
> +    virDrvDomainSendKey domainSendKey;
>  };
>  

ACK looks fine wrt to whatever the public API ends up being

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|