[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix 'make dist' for ./configure --without-remote



On 05/15/2011 08:51 PM, Wen Congyang wrote:
> At 05/12/2011 04:30 AM, Eric Blake Write:
>> Anything generated that must end up in the tarball must either
>> have unconditional rules for generation (remote_protocol.c) or
>> must live in libvirt.git for the case where the person running
>> 'make dist' has disabled the configure options that control the
>> rebuild of the generated file (remote_protocol-structs).
>>
>> * src/Makefile.am (remote_protocol-structs): Add a dependency and
>> document why it must live in git.
>> ($(srcdir)/remote/%_protocol.c, $(srcdir)/remote/%_protocol.c):
>> Unconditionally generate.
>> ---
>>
>> This should be the last piece of the puzzle for fixing an issue
>> that I first pointed out here:
>> https://www.redhat.com/archives/libvir-list/2011-May/msg00343.html

This patch still isn't in.  Should it be?

>>  .PHONY: remote_protocol-structs
>> -remote_protocol-structs:
>> +if WITH_REMOTE
>> +remote_protocol-structs: libvirt_driver_remote_la-remote_protocol.$(OBJEXT)
> 
> This line will introduce another problem for ./configure --with-remote:
> make[1]: *** No rule to make target `libvirt_driver_remote_la-remote_protocol.o', needed by `remote_protocol-structs'.  Stop.
> make[1]: Leaving directory `/home/wency/source/libvirt-nodaemon/src'
> make: *** [distdir] Error 1

I can't reproduce that failure on Fedora 14.  What system were you on?
Perhaps it is dependent on libtool version or automake version used to
generate the Makefile?  Should I isolate this change from the rest of
the patch, so that 'make dist' works better from a --without-remote setup?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]