[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Libvirt-test-API][PATCH] Modify try/except/finally format in all testcases for python backward compatibility



于 2011年05月23日 22:23, Guannan Ren 写道:
From: Wayne Sun<gsun redhat com>

* modify all cases under repos/ of try/except/finally format
* delete utils/Python/virt.cfg which in wrong place

Signed-off-by: Guannan Ren<gren redhat com>
---
  repos/domain/attach_disk.py            |   29 ++++----
  repos/domain/attach_interface.py       |   29 ++++----
  repos/domain/autostart.py              |   29 ++++----
  repos/domain/blkstats.py               |    9 +-
  repos/domain/create.py                 |   13 ++--
  repos/domain/define.py                 |   19 +++--
  repos/domain/destroy.py                |   13 ++--
  repos/domain/detach_disk.py            |   29 ++++----
  repos/domain/detach_interface.py       |   31 ++++----
  repos/domain/domain_uuid.py            |   25 +++---
  repos/domain/reboot.py                 |   13 ++--
  repos/domain/save.py                   |   25 +++---
  repos/domain/undefine.py               |   19 +++--
  repos/interface/create.py              |   29 ++++----
  repos/interface/define.py              |   25 +++---
  repos/interface/destroy.py             |   29 ++++----
  repos/interface/undefine.py            |   25 +++---
  repos/network/autostart.py             |   39 +++++-----
  repos/network/create.py                |   31 ++++----
  repos/network/define.py                |   29 ++++----
  repos/network/destroy.py               |   31 ++++----
  repos/network/network_name.py          |   25 +++---
  repos/network/network_uuid.py          |   25 +++---
  repos/network/undefine.py              |   29 ++++----
  repos/nodedevice/detach.py             |   33 ++++----
  repos/nodedevice/reattach.py           |   33 ++++----
  repos/nodedevice/reset.py              |   21 +++---
  repos/npiv/create_virtual_hba.py       |   35 +++++----
  repos/snapshot/delete.py               |   23 +++---
  repos/snapshot/internal_create.py      |   15 ++--
  repos/snapshot/revert.py               |   15 ++--
  repos/storage/activate_pool.py         |   23 +++---
  repos/storage/build_dir_pool.py        |   27 ++++---
  repos/storage/build_disk_pool.py       |   27 ++++---
  repos/storage/build_logical_pool.py    |   29 ++++----
  repos/storage/build_netfs_pool.py      |   27 ++++---
  repos/storage/create_dir_pool.py       |   25 +++---
  repos/storage/create_dir_volume.py     |   13 ++--
  repos/storage/create_fs_pool.py        |   35 +++++----
  repos/storage/create_iscsi_pool.py     |   25 +++---
  repos/storage/create_logical_volume.py |   31 ++++----
  repos/storage/create_netfs_pool.py     |   35 +++++----
  repos/storage/create_netfs_volume.py   |   13 ++--
  repos/storage/define_dir_pool.py       |   37 +++++-----
  repos/storage/define_disk_pool.py      |   31 ++++----
  repos/storage/define_iscsi_pool.py     |   29 ++++----
  repos/storage/define_logical_pool.py   |   29 ++++----
  repos/storage/define_mpath_pool.py     |   31 ++++----
  repos/storage/define_netfs_pool.py     |   29 ++++----
  repos/storage/define_scsi_pool.py      |   31 ++++----
  repos/storage/delete_dir_volume.py     |   27 ++++---
  repos/storage/delete_logical_pool.py   |   29 ++++----
  repos/storage/delete_logical_volume.py |   31 ++++----
  repos/storage/delete_netfs_volume.py   |   27 ++++---
  repos/storage/pool_name.py             |   23 +++---
  repos/storage/pool_uuid.py             |   23 +++---
  repos/storage/undefine_pool.py         |   29 ++++----
  utils/Python/virt.cfg                  |  129 --------------------------------
  58 files changed, 774 insertions(+), 846 deletions(-)
  delete mode 100644 utils/Python/virt.cfg


Quite big patch, but the pricinple is very simple, doing the same
fixing on all the related scripts.

Looks good to me, ACK.

Regards
Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]