[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Add device disk attach/detach support to libxl driver



On Wed, May 18, 2011 at 10:06:35AM +0200, Markus Groß wrote:
> This patch series adds the infrastructure to support
> attaching and detaching of devices to the libxl driver.
> Currently only disk devices are supported.
> 
> The first patch refactors some functions that
> are needed to create the appropriate datastructures
> for the libxenlight interface.
> The second patch fixes the handling of vm def's on cleanup.
> The last patch finally adds the device attach/detach code
> and follows qemu's implementation.
> 
> Markus Groß (3):
>   Refactored libxl datastructure instantiation
>   Fix libxl vm def handling on domU cleanup
>   Add disk attach/detach support to libxl driver
> 
>  src/libxl/libxl_conf.c   |  304 ++++++++++++++-------------
>  src/libxl/libxl_conf.h   |    8 +
>  src/libxl/libxl_driver.c |  526 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 697 insertions(+), 141 deletions(-)

  Okay, the patch set looks fine. Somehow 2/3 is independant since it's
a bug fix on the current state but I kept the patch order. I also
applied the small comment fix on 3/3,

  thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]