Re: [libvirt] [PATCHv4 0/7] interface: new public API for network config change transactions

[Daniel Veillard <veillard redhat com>]

On Thu, May 26, 2011 at 12:17:38PM -0400, Laine Stump wrote:
> 
> (This is v3 of some of the patches and v4 of some others. Changes from
> previous versions are noted in the individual patches.)
> 
> This patch series implements three new APIs for the interface
> driver which support transactional changes to the host's network
> config - at any point you can begin a transaction (which saves a
> snapshot of the current config), then make any changes you like to the
> config, and later either commit those changes (the current
> implementation just removes the snapshotted files) or rollback to the
> original config.
> 
> The actual implementation of this functionality lives in the netcf
> library; these patches create pass-through functions that call out to
> netcf on the machine that's running libvirtd.
> 
> Most importantly, note that uses of "start" in the API names have been
> changed to "begin", and rather than a single virsh command with
> multiple subcommands, there are now three separate commands:
> iface-begin, iface-commit, and iface-rollback.
> 
> Thanks to using AC_CHECK_LIB in configure.ac, this code can safely be
> pushed and built on systems that don't yet have a new enough netcf to
> contain the API extensions - those functions are simply not
> implemented in that case (and return the appropriate error).

  ACK from me for the whole set, please push :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/